Add support for switch expressions #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Dec 17, 2021
jdk17-unit-tests/build.gradle
Outdated
| } | ||
|
|
||
| coverallsJacoco { | ||
| reportPath = "jdk17-unit-tests/build/reports/jacoco/test/jacocoTestReport.xml" |
There was a problem hiding this comment.
We have an issue of separate coverage files for these tests and the main NullAway tests, so Coveralls may complain. A possible solution is here: https://discuss.gradle.org/t/merge-jacoco-coverage-reports-for-multiproject-setups/12100/6 I propose we go ahead with landing this PR and solve the coverage issue in a follow-up
msridhar
commented
Dec 17, 2021
| ExpressionTree switchExpression = tree.getExpression(); | ||
| if (switchExpression instanceof ParenthesizedTree) { | ||
| switchExpression = ((ParenthesizedTree) switchExpression).getExpression(); | ||
| ExpressionTree switchSelectorExpression = tree.getExpression(); |
There was a problem hiding this comment.
This is just a variable rename (to avoid confusion with switch expressions) and also a comment to explain why parens are being removed
|
Working on trying to aggregate coverage, switching to draft for now |
|
Closing since Coveralls only works when the PR is from a branch on the origin repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289
Checker Framework 3.21.0 added support for switch expressions; we build on that to support the expressions in NullAway. We also add a
jdk17-unit-testsmodule to test the support (which requires a JDK 12+ compiler).