Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Checker Framework 3.22.2 #610

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

lazaroclapp
Copy link
Collaborator

Needed for our changes in #608, which requires visibility into some previously
package or private level internals of Checker Framework's CFG:

Copy link
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want / need to perf test this on its own. The data flow library is pretty stable
these days

@coveralls
Copy link

Pull Request Test Coverage Report for Build #871

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 92.143%

Totals Coverage Status
Change from base Build #869: 0.04%
Covered Lines: 4773
Relevant Lines: 5180

💛 - Coveralls

@lazaroclapp
Copy link
Collaborator Author

Not sure if we want / need to perf test this on its own. The data flow library is pretty stable these days

We probably want perf testing on #608 itself once that is ready - if you haven't checked already - but your call on the dependency upgrade itself. Would be nice if perf testing was automated for every PR, but I imagine that's far from trivial :)

@msridhar
Copy link
Collaborator

I did an overhead measurement for #608 (which currently includes this change) and everything was fine; so I think this should be ok on its own.

@lazaroclapp lazaroclapp merged commit 08c50cf into master Jun 16, 2022
@msridhar msridhar deleted the lazaro_upgrade_checker_framework_3_22_2 branch September 4, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants