Refactor code to use Map.getOrDefault where possible
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaroclapp
reviewed
Feb 2, 2023
There was a problem hiding this comment.
LGTM.
As a minor nit, could I ask for the title to be changed to "Refactor code to use Map.getOrDefault where possible" or something similar that indicates this is an internal refactoring? (to make it easier to use it as is for the changelog 🙂 )
Edit: Actually, going ahead and renaming this one and landing, hopefully that's ok by you.
lazaroclapp
changed the title
Map.getOrDefaultMap.getOrDefault where possible
lazaroclapp
approved these changes
Feb 2, 2023
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit ed0ef72.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit ed0ef72.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit ed0ef72.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit ed0ef72.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit ed0ef72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.