Add JSpecify checking for return statements #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
msridhar
changed the title
msridhar
added
the
jspecify
|
@lazaroclapp I already did a few passes on this one. It'd be great if you could take a look, when you have time |
lazaroclapp
reviewed
Feb 22, 2023
nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
Outdated
Show resolved
Hide resolved
lazaroclapp
approved these changes
Feb 22, 2023
| @@ -151,8 +151,10 @@ private static void reportInvalidReturnTypeError( | |||
| } | |||
|
|
|||
| /** | |||
| * This method returns type of the tree considering that the parameterized typed tree annotations | |||
| * are not preserved if obtained directly using ASTHelpers. | |||
| * This method returns the type of the tree, including any type use annotations. This is required | |||
There was a problem hiding this comment.
I would still introduce a paragraph break after the first line here. Since the first line is a description of what the method does and the rest is additional explanation. It might need a <p> at the beginning of the new paragraph in order for GJF to not reformat it...
nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
Outdated
Show resolved
Hide resolved
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit 1548c69.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit 1548c69.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit 1548c69.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit 1548c69.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit 1548c69.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following:
static A<@Nullable String> test() { return new A<String>(); }For the method return type, the type parameter is @nullable String and the type of the type parameter of the actual return statement is NonNull. NullAway will report an error here.