Upgrade to Gradle 8.1.1 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded by running twice: ./gradlew wrapper --gradle-version 8.1.1 --gradle-distribution-sha256-sum e111cb9948407e26351227dabce49822fb88c37ee72f1d1582a69c68af2e702f see also: https://gradle.org/release-checksums/ https://docs.gradle.org/8.1.1/release-notes.html
XN137
commented
May 14, 2023
There was a problem hiding this comment.
➜ NullAway git:(upgrade-gradle) sha256sum gradle/wrapper/gradle-wrapper.jar
ed2c26eba7cfb93cc2b7785d05e534f07b5b48b5e7fc941921cd098628abca58 gradle/wrapper/gradle-wrapper.jar
compare with https://gradle.org/release-checksums/
This was referenced Jun 14, 2023
lazaroclapp
added a commit
that referenced
this pull request
Jun 14, 2023
…767) A recent upgrade to our gradle version (#762) silently broke our publishing flows. In particular, `publish` and `publishToMavenLocal` are broken on Java 8, resulting in the following error: ``` Execution failed for task ':annotations:publishMavenPublicationToMavenLocal'. > Failed to publish publication 'maven' to repository 'mavenLocal' > Invalid publication 'maven': artifact file does not exist: '/home/runner/work/NullAway/NullAway/annotations/build/publications/maven/module.json.asc' ``` See this [CI job run](https://github.com/uber/NullAway/actions/runs/5261437721/jobs/9509542067?pr=767). There are further errors when the release is signed. Below, we revert the gradle upgrade, and also add a CI job running `publishToMavenLocal` to prevent future regressions (We can't trivially test signing these publications in a secure manner, unfortunately, so we skip that for now. If that specifically breaks in the future, we could provide a test gpg key for signing in CI).
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit eea2a9a.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit eea2a9a.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit eea2a9a.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit eea2a9a.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit eea2a9a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgraded by running twice:
see also:
https://gradle.org/release-checksums/
https://docs.gradle.org/8.1.1/release-notes.html