Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Spotless for formatting Java code #780

Merged
merged 4 commits into from
Jul 15, 2023

Conversation

msridhar
Copy link
Collaborator

Our previous plugin for running Google Java Format was unmaintained. Also update our version of GJF, which leads to minor formatting changes.

In follow-ups, we can use Spotless to enforce formatting for .gradle files and also make license headers consistent.

@@ -1,4 +1,5 @@
package com.uber.nullaway.handlers;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix these incorrectly-placed license headers in a follow-up

@@ -13,7 +13,6 @@ include ':sample'
include ':test-java-lib'
include ':test-java-lib-lombok'
include ':test-library-models'
include ':compile-bench'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuring Spotless made me notice this project no longer exists in the repo

Copy link
Contributor

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@msridhar msridhar merged commit 31004d3 into master Jul 15, 2023
8 checks passed
@msridhar msridhar deleted the switch-to-spotless-formatting branch July 15, 2023 17:46
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants