Update to Gradle 8.2.1 #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaroclapp
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to back out a previous Gradle upgrade, but I believe now things have been fixed up enough that we can upgrade again. One issue with the upgrade is that publishing a build will fail if signing is not functional and the version is not a
SNAPSHOT. In particular, with our default config,LOCALversions must be signed. (This was the documented behavior before this Gradle upgrade but for some reason the build wasn't failing.) So, publishingLOCALbuilds without signing requires disabling a setting via a Gradle property or env var. We update the CI config and the docs to reflect this.I tested publishing a release to Sonatype (without pushing to Maven Central) from my laptop and it succeeded. I have not yet validated the actual artifacts. Will hold off on landing this until we're sure it's thoroughly tested.
Fixes #768