Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable daemon when running benchmarks #786

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Disable daemon when running benchmarks #786

merged 1 commit into from
Jul 18, 2023

Conversation

msridhar
Copy link
Collaborator

This might reduce the noise a bit when running benchmarks (since old daemon processes won't be running).

ketkarameya
ketkarameya approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msridhar msridhar merged commit 45cc4c2 into uber:master Jul 18, 2023
8 checks passed
@msridhar msridhar deleted the benchmarks-disable-daemon branch July 18, 2023 16:23
@msridhar
Copy link
Collaborator Author

Thanks for the quick review @ketkarameya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketkarameya ketkarameya ketkarameya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msridhar @ketkarameya