Update to Error Prone 2.21.1 #797
Conversation
| @@ -21,16 +21,16 @@ jobs: | |||
| epVersion: 2.4.0 | |||
| - os: macos-latest | |||
| java: 11 | |||
| epVersion: 2.20.0 | |||
| epVersion: 2.21.0 | |||
There was a problem hiding this comment.
Seeing this change, I wonder if there is a way to define this version as a constant once in this yml and reference it in all these jobs and the check below, like we do inside gradle :)
There was a problem hiding this comment.
Unfortunately this is not possible. You can define variables in an env context but you can't use them when specifying properties in the matrix, see here.
| * processed by {@link #onMatchTopLevelClass(NullAway, ClassTree, VisitorState, | ||
| * Symbol.ClassSymbol)} | ||
| */ | ||
| @Initializer |
There was a problem hiding this comment.
Just out of curiosity, was there any issue marking onMatchTopLevelClass(...) itself as an initializer? Or is there a reason why that would be confusing? (I guess for all handlers, in general, we would expect that to be the first callback executed always?)
There was a problem hiding this comment.
You're right, just annotating onMatchTopLevelClass(...) is better, and I switched to that. It's slightly strange since that method gets invoked multiple times (once for each class), but it does perform guaranteed initialization the first time it runs, so I think it's fine to annotate it as @Initializer.
Mostly straightforward. Error Prone has a new NullableOptional check that warned on a couple instances in our code base. I changed these cases to use an
@Initializermethod which I think better captures what is going on. Will update the required CI checks before landing.