Allow library models to define custom stream classes. #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1172
💛 - Coveralls |
|
/benchmark |
msridhar
reviewed
Aug 17, 2023
Comment on lines
304
to
307
| // Note: Currently, OptimizedLibraryModels doesn't carry the information about stream type | ||
| // records, | ||
| // it is not clear what it means to "optimize" lookup for those and they get access only once: | ||
| // here. |
| @@ -90,6 +92,10 @@ public StreamModelBuilder addStreamType(TypePredicate tp) { | |||
| return this; | |||
| } | |||
|
|
|||
| public StreamModelBuilder addStreamTypeFromName(String fullyQualifiedName) { | |||
| * <p>This handler must be registered in Handlers.java separatedly from the LibraryModelsHandler | ||
| * itself. | ||
| */ | ||
| public StreamNullabilityPropagator getStreamNullabilityPropagatorFromModels() { |
There was a problem hiding this comment.
It seems a bit awkward to put this method here as opposed to StreamNullabilityPropagatorFactory. Is it here because it needs access to the libraryModels object which is encapsulated within this class?
There was a problem hiding this comment.
Yeah, libraryModels combines all loaded library models from auto-service, and I am not sure I want to provide a way to retrieve it from this class. What we could do is:
- Add
getCustomStreamNullabilitySpecs()to this handler, which returnslibraryModels.customStreamNullabilitySpecs() - Add a static method to
StreamNullabilityPropagatorFactorywhich takes that and returns theStreamNullabilityPropagator
There was a problem hiding this comment.
I'm fine with whatever you think is cleanest
|
Main Branch: With This PR: |
msridhar
approved these changes
Aug 18, 2023
lazaroclapp
force-pushed
the
lazaro_stream_handler_with_method_refs
branch
from
364adc6
to
1b4c6fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support both fully custom stream libraries, as well as backports/shadowed versions
of existing stream libraries.