Ensure castToNonNull insertion/removal suggested fixes do not remove comments #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1185
💛 - Coveralls |
lazaroclapp
approved these changes
Aug 25, 2023
| " static class Foo { @Nullable Object getObj() { return null; } }", | ||
| " Object test1(Foo f) {", | ||
| " return f", | ||
| " // comment that should not be deleted", |
There was a problem hiding this comment.
What happens in the nonNullF = nullVal; // some comment case? Just nonNullF = castToNonNull(nullVal); // some comment, I assume?
Is there any case you can imagine where the comment ends up inside the castToNonNull(...) call like here, but without a newline between the comment and )?
There was a problem hiding this comment.
I'll add a couple more tests. We could also have castToNonNull(f./* comment */getObj())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now preserve the original source code of the AST node for which we are adding or removing a cast, ensuring that comments within the node are preserved.