-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for nullable type upper bounds considering Library mod… #893
Commits on Jan 10, 2024
-
Adding support for nullable type upper bounds considering Library mod…
…els for generic types
Configuration menu - View commit details
-
Copy full SHA for f71df65 - Browse repository at this point
Copy the full SHA f71df65View commit details -
Configuration menu - View commit details
-
Copy full SHA for e27b474 - Browse repository at this point
Copy the full SHA e27b474View commit details
Commits on Jan 11, 2024
-
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
…and updating relevant implementations.
Configuration menu - View commit details
-
Copy full SHA for 529a26b - Browse repository at this point
Copy the full SHA 529a26bView commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f10c491 - Browse repository at this point
Copy the full SHA f10c491View commit details -
Configuration menu - View commit details
-
Copy full SHA for b122a66 - Browse repository at this point
Copy the full SHA b122a66View commit details
Commits on Jan 15, 2024
-
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 50578d7 - Browse repository at this point
Copy the full SHA 50578d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 273a959 - Browse repository at this point
Copy the full SHA 273a959View commit details -
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
…7' into library_models_Function_abhijitk7 # Conflicts: # nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
Configuration menu - View commit details
-
Copy full SHA for 88a4799 - Browse repository at this point
Copy the full SHA 88a4799View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7849690 - Browse repository at this point
Copy the full SHA 7849690View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce9609c - Browse repository at this point
Copy the full SHA ce9609cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b56733a - Browse repository at this point
Copy the full SHA b56733aView commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 81f8b7d - Browse repository at this point
Copy the full SHA 81f8b7dView commit details -
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
…terface" This reverts commit 81f8b7d. "Reverting EmptyLibraryModels changes"
Configuration menu - View commit details
-
Copy full SHA for 488f005 - Browse repository at this point
Copy the full SHA 488f005View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2634b16 - Browse repository at this point
Copy the full SHA 2634b16View commit details -
Adding default implementations for typeVariablesWithNullableUpperBoun…
…ds and nullableFields
Configuration menu - View commit details
-
Copy full SHA for 2730d2a - Browse repository at this point
Copy the full SHA 2730d2aView commit details -
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
…sHandler.java Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ec115af - Browse repository at this point
Copy the full SHA ec115afView commit details -
Removing redundant default implementations from ExampleLibraryModels …
…and TestLibraryModels
Configuration menu - View commit details
-
Copy full SHA for f72959f - Browse repository at this point
Copy the full SHA f72959fView commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3e0fb0b - Browse repository at this point
Copy the full SHA 3e0fb0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee15c59 - Browse repository at this point
Copy the full SHA ee15c59View commit details
Commits on Jan 22, 2024
-
Adding support for nullable type upper bounds considering Library mod…
…els for generic types
Configuration menu - View commit details
-
Copy full SHA for f7462aa - Browse repository at this point
Copy the full SHA f7462aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee3522 - Browse repository at this point
Copy the full SHA 2ee3522View commit details -
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
…and updating relevant implementations.
Configuration menu - View commit details
-
Copy full SHA for 8699e85 - Browse repository at this point
Copy the full SHA 8699e85View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae62aaa - Browse repository at this point
Copy the full SHA ae62aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3eb477 - Browse repository at this point
Copy the full SHA c3eb477View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3e17cf - Browse repository at this point
Copy the full SHA c3e17cfView commit details -
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 107d40c - Browse repository at this point
Copy the full SHA 107d40cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e80e35f - Browse repository at this point
Copy the full SHA e80e35fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cfd0e2 - Browse repository at this point
Copy the full SHA 0cfd0e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1af63 - Browse repository at this point
Copy the full SHA dc1af63View commit details -
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
…terface" This reverts commit 81f8b7d. "Reverting EmptyLibraryModels changes"
Configuration menu - View commit details
-
Copy full SHA for e4d5813 - Browse repository at this point
Copy the full SHA e4d5813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bf421d - Browse repository at this point
Copy the full SHA 3bf421dView commit details -
Adding default implementations for typeVariablesWithNullableUpperBoun…
…ds and nullableFields
Configuration menu - View commit details
-
Copy full SHA for 334af66 - Browse repository at this point
Copy the full SHA 334af66View commit details -
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
…sHandler.java Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 20f3fe1 - Browse repository at this point
Copy the full SHA 20f3fe1View commit details -
Removing redundant default implementations from ExampleLibraryModels …
…and TestLibraryModels
Configuration menu - View commit details
-
Copy full SHA for 2453b08 - Browse repository at this point
Copy the full SHA 2453b08View commit details -
Configuration menu - View commit details
-
Copy full SHA for c70ec1d - Browse repository at this point
Copy the full SHA c70ec1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84247a2 - Browse repository at this point
Copy the full SHA 84247a2View commit details -
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
…7' into library_models_Function_abhijitk7 # Conflicts: # nullaway/src/main/java/com/uber/nullaway/LibraryModels.java # nullaway/src/main/java/com/uber/nullaway/handlers/BaseNoOpHandler.java # nullaway/src/main/java/com/uber/nullaway/handlers/CompositeHandler.java # nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java # nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java # nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
Configuration menu - View commit details
-
Copy full SHA for ac94e7a - Browse repository at this point
Copy the full SHA ac94e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b92af4 - Browse repository at this point
Copy the full SHA 6b92af4View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 27918ff - Browse repository at this point
Copy the full SHA 27918ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 026970c - Browse repository at this point
Copy the full SHA 026970cView commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4e829d7 - Browse repository at this point
Copy the full SHA 4e829d7View commit details -
Fix bug with implicit equals() methods in interfaces (uber#898)
Fixes uber#897 This fixes a regression in our handling of implicit `equals()` methods in interfaces when building on JDK 21. I see this as an interim fix, until we can fix NullAway to properly always assume / enforce that the parameter of `equals()` is `@Nullable`. But, I think we should fix the regression in the short term.
Configuration menu - View commit details
-
Copy full SHA for b94597a - Browse repository at this point
Copy the full SHA b94597aView commit details -
Fix crash with raw types in overrides in JSpecify mode (uber#899)
We should skip checking for errors here instead of crashing
Configuration menu - View commit details
-
Copy full SHA for 091ac38 - Browse repository at this point
Copy the full SHA 091ac38View commit details -
Update instructions for Android and our sample app (uber#900)
Fixes uber#891. It's hard to add a regression test for this, but I manually tested that with the new configuration, NullAway errors are detected in the sample app. After this lands, I'd like to update the readme further to refer to this particular commit, so users can see the changes we needed to make.
Configuration menu - View commit details
-
Copy full SHA for 115d683 - Browse repository at this point
Copy the full SHA 115d683View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 373917e - Browse repository at this point
Copy the full SHA 373917eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 986d060 - Browse repository at this point
Copy the full SHA 986d060View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00a317a - Browse repository at this point
Copy the full SHA 00a317aView commit details -
Adding support for nullable type upper bounds considering Library mod…
…els for generic types
Configuration menu - View commit details
-
Copy full SHA for 35eac21 - Browse repository at this point
Copy the full SHA 35eac21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71cecb4 - Browse repository at this point
Copy the full SHA 71cecb4View commit details -
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
…and updating relevant implementations.
Configuration menu - View commit details
-
Copy full SHA for 18a0c6d - Browse repository at this point
Copy the full SHA 18a0c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f28ff5 - Browse repository at this point
Copy the full SHA 1f28ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c911842 - Browse repository at this point
Copy the full SHA c911842View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aea517 - Browse repository at this point
Copy the full SHA 9aea517View commit details -
Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba88839 - Browse repository at this point
Copy the full SHA ba88839View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75436eb - Browse repository at this point
Copy the full SHA 75436ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 865873e - Browse repository at this point
Copy the full SHA 865873eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91a12f4 - Browse repository at this point
Copy the full SHA 91a12f4View commit details -
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
…terface" This reverts commit 81f8b7d. "Reverting EmptyLibraryModels changes"
Configuration menu - View commit details
-
Copy full SHA for db16c7a - Browse repository at this point
Copy the full SHA db16c7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 836ff44 - Browse repository at this point
Copy the full SHA 836ff44View commit details -
Adding default implementations for typeVariablesWithNullableUpperBoun…
…ds and nullableFields
Configuration menu - View commit details
-
Copy full SHA for 6a9d7c1 - Browse repository at this point
Copy the full SHA 6a9d7c1View commit details -
Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…
…sHandler.java Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cea3614 - Browse repository at this point
Copy the full SHA cea3614View commit details -
Removing redundant default implementations from ExampleLibraryModels …
…and TestLibraryModels
Configuration menu - View commit details
-
Copy full SHA for 7bf7497 - Browse repository at this point
Copy the full SHA 7bf7497View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37c7cb0 - Browse repository at this point
Copy the full SHA 37c7cb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26c82dd - Browse repository at this point
Copy the full SHA 26c82ddView commit details -
Adding support for nullable type upper bounds considering Library mod…
…els for generic types
Configuration menu - View commit details
-
Copy full SHA for cd0e659 - Browse repository at this point
Copy the full SHA cd0e659View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bf78df - Browse repository at this point
Copy the full SHA 1bf78dfView commit details -
Adding method onOverrideTypeParameterUpperBound to Handler Interface …
…and updating relevant implementations.
Configuration menu - View commit details
-
Copy full SHA for 268022a - Browse repository at this point
Copy the full SHA 268022aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e5df6a - Browse repository at this point
Copy the full SHA 5e5df6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c24cbd - Browse repository at this point
Copy the full SHA 6c24cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32f84ac - Browse repository at this point
Copy the full SHA 32f84acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f6d9a8 - Browse repository at this point
Copy the full SHA 5f6d9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcc1507 - Browse repository at this point
Copy the full SHA dcc1507View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bba915 - Browse repository at this point
Copy the full SHA 4bba915View commit details -
Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…
…terface" This reverts commit 81f8b7d. "Reverting EmptyLibraryModels changes"
Configuration menu - View commit details
-
Copy full SHA for d24e9c5 - Browse repository at this point
Copy the full SHA d24e9c5View commit details -
Adding default implementations for typeVariablesWithNullableUpperBoun…
…ds and nullableFields
Configuration menu - View commit details
-
Copy full SHA for 2ba7932 - Browse repository at this point
Copy the full SHA 2ba7932View commit details -
Removing redundant default implementations from ExampleLibraryModels …
…and TestLibraryModels
Configuration menu - View commit details
-
Copy full SHA for 2ea0b77 - Browse repository at this point
Copy the full SHA 2ea0b77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c1316d - Browse repository at this point
Copy the full SHA 1c1316dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 924396c - Browse repository at this point
Copy the full SHA 924396cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d5ed0 - Browse repository at this point
Copy the full SHA 24d5ed0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de4d12 - Browse repository at this point
Copy the full SHA 0de4d12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32aef72 - Browse repository at this point
Copy the full SHA 32aef72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2acffb3 - Browse repository at this point
Copy the full SHA 2acffb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1e23d1 - Browse repository at this point
Copy the full SHA e1e23d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb23172 - Browse repository at this point
Copy the full SHA fb23172View commit details
Commits on Jan 30, 2024
-
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
…7' into library_models_Function_abhijitk7 # Conflicts: # nullaway/src/main/java/com/uber/nullaway/CodeAnnotationInfo.java # nullaway/src/main/java/com/uber/nullaway/LibraryModels.java # nullaway/src/main/java/com/uber/nullaway/NullAway.java # nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java # nullaway/src/main/java/com/uber/nullaway/handlers/CompositeHandler.java # nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java # nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
Configuration menu - View commit details
-
Copy full SHA for bc0edd1 - Browse repository at this point
Copy the full SHA bc0edd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dd0ca6 - Browse repository at this point
Copy the full SHA 2dd0ca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for badfd16 - Browse repository at this point
Copy the full SHA badfd16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc4337 - Browse repository at this point
Copy the full SHA 6fc4337View commit details -
Merge remote-tracking branch 'origin/library_models_Function_abhijitk…
…7' into library_models_Function_abhijitk7 # Conflicts: # nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
Configuration menu - View commit details
-
Copy full SHA for c97e8dc - Browse repository at this point
Copy the full SHA c97e8dcView commit details -
Revert "Prepare next development version."
This reverts commit 00a317a.
Configuration menu - View commit details
-
Copy full SHA for 05fe856 - Browse repository at this point
Copy the full SHA 05fe856View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a2008 - Browse repository at this point
Copy the full SHA 37a2008View commit details -
Revert "Update instructions for Android and our sample app (uber#900)"
This reverts commit 115d683.
Configuration menu - View commit details
-
Copy full SHA for 57a2116 - Browse repository at this point
Copy the full SHA 57a2116View commit details -
Revert "Fix crash with raw types in overrides in JSpecify mode (uber#899
)" This reverts commit 091ac38
Configuration menu - View commit details
-
Copy full SHA for e2beddc - Browse repository at this point
Copy the full SHA e2beddcView commit details -
Fix crash with raw types in overrides in JSpecify mode (uber#899)
We should skip checking for errors here instead of crashing (cherry picked from commit 091ac38)
Configuration menu - View commit details
-
Copy full SHA for f6996d1 - Browse repository at this point
Copy the full SHA f6996d1View commit details