Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nullable type upper bounds considering Library mod… #893

Closed

Commits on Jan 10, 2024

  1. Adding support for nullable type upper bounds considering Library mod…

    …els for generic types
    akulk022 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f71df65 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e27b474 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Adding method onOverrideTypeParameterUpperBound to Handler Interface …

    …and updating relevant implementations.
    akulk022 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    529a26b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Updating java docs

    akulk022 committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    f10c491 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b122a66 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java

    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    50578d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    273a959 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/library_models_Function_abhijitk…

    …7' into library_models_Function_abhijitk7
    
    # Conflicts:
    #	nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
    akulk022 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    88a4799 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7849690 View commit details
    Browse the repository at this point in the history
  5. using putAll instead of loop

    akulk022 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    ce9609c View commit details
    Browse the repository at this point in the history
  6. adding positive test case

    akulk022 committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b56733a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    81f8b7d View commit details
    Browse the repository at this point in the history
  2. Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…

    …terface"
    
    This reverts commit 81f8b7d.
    
    "Reverting EmptyLibraryModels changes"
    akulk022 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    488f005 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2634b16 View commit details
    Browse the repository at this point in the history
  4. Adding default implementations for typeVariablesWithNullableUpperBoun…

    …ds and nullableFields
    akulk022 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2730d2a View commit details
    Browse the repository at this point in the history
  5. Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…

    …sHandler.java
    
    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ec115af View commit details
    Browse the repository at this point in the history
  6. Removing redundant default implementations from ExampleLibraryModels …

    …and TestLibraryModels
    akulk022 committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f72959f View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    3e0fb0b View commit details
    Browse the repository at this point in the history
  2. documentation improvements

    msridhar committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ee15c59 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Adding support for nullable type upper bounds considering Library mod…

    …els for generic types
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f7462aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ee3522 View commit details
    Browse the repository at this point in the history
  3. Adding method onOverrideTypeParameterUpperBound to Handler Interface …

    …and updating relevant implementations.
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8699e85 View commit details
    Browse the repository at this point in the history
  4. Updating java docs

    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ae62aaa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c3eb477 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3e17cf View commit details
    Browse the repository at this point in the history
  7. Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java

    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    107d40c View commit details
    Browse the repository at this point in the history
  8. using putAll instead of loop

    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e80e35f View commit details
    Browse the repository at this point in the history
  9. adding positive test case

    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0cfd0e2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dc1af63 View commit details
    Browse the repository at this point in the history
  11. Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…

    …terface"
    
    This reverts commit 81f8b7d.
    
    "Reverting EmptyLibraryModels changes"
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e4d5813 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3bf421d View commit details
    Browse the repository at this point in the history
  13. Adding default implementations for typeVariablesWithNullableUpperBoun…

    …ds and nullableFields
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    334af66 View commit details
    Browse the repository at this point in the history
  14. Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…

    …sHandler.java
    
    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20f3fe1 View commit details
    Browse the repository at this point in the history
  15. Removing redundant default implementations from ExampleLibraryModels …

    …and TestLibraryModels
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2453b08 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c70ec1d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    84247a2 View commit details
    Browse the repository at this point in the history
  18. Merge remote-tracking branch 'origin/library_models_Function_abhijitk…

    …7' into library_models_Function_abhijitk7
    
    # Conflicts:
    #	nullaway/src/main/java/com/uber/nullaway/LibraryModels.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/BaseNoOpHandler.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/CompositeHandler.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java
    #	nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
    akulk022 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ac94e7a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    6b92af4 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. bug fix, still more to do

    msridhar committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    27918ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    026970c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    4e829d7 View commit details
    Browse the repository at this point in the history
  2. Fix bug with implicit equals() methods in interfaces (uber#898)

    Fixes uber#897 
    
    This fixes a regression in our handling of implicit `equals()` methods
    in interfaces when building on JDK 21. I see this as an interim fix,
    until we can fix NullAway to properly always assume / enforce that the
    parameter of `equals()` is `@Nullable`. But, I think we should fix the
    regression in the short term.
    msridhar committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b94597a View commit details
    Browse the repository at this point in the history
  3. Fix crash with raw types in overrides in JSpecify mode (uber#899)

    We should skip checking for errors here instead of crashing
    msridhar committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    091ac38 View commit details
    Browse the repository at this point in the history
  4. Update instructions for Android and our sample app (uber#900)

    Fixes uber#891. It's hard to add a regression test for this, but I manually
    tested that with the new configuration, NullAway errors are detected in
    the sample app. After this lands, I'd like to update the readme further
    to refer to this particular commit, so users can see the changes we
    needed to make.
    msridhar committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    115d683 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. docs

    msridhar committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    373917e View commit details
    Browse the repository at this point in the history
  2. Prepare for release 0.10.22.

    yuxincs committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    986d060 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00a317a View commit details
    Browse the repository at this point in the history
  4. Adding support for nullable type upper bounds considering Library mod…

    …els for generic types
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    35eac21 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    71cecb4 View commit details
    Browse the repository at this point in the history
  6. Adding method onOverrideTypeParameterUpperBound to Handler Interface …

    …and updating relevant implementations.
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    18a0c6d View commit details
    Browse the repository at this point in the history
  7. Updating java docs

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1f28ff5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c911842 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9aea517 View commit details
    Browse the repository at this point in the history
  10. Update nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java

    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ba88839 View commit details
    Browse the repository at this point in the history
  11. using putAll instead of loop

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    75436eb View commit details
    Browse the repository at this point in the history
  12. adding positive test case

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    865873e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    91a12f4 View commit details
    Browse the repository at this point in the history
  14. Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…

    …terface"
    
    This reverts commit 81f8b7d.
    
    "Reverting EmptyLibraryModels changes"
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    db16c7a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    836ff44 View commit details
    Browse the repository at this point in the history
  16. Adding default implementations for typeVariablesWithNullableUpperBoun…

    …ds and nullableFields
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6a9d7c1 View commit details
    Browse the repository at this point in the history
  17. Update nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModel…

    …sHandler.java
    
    Co-authored-by: Manu Sridharan <msridhar@gmail.com>
    akulk022 and msridhar committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    cea3614 View commit details
    Browse the repository at this point in the history
  18. Removing redundant default implementations from ExampleLibraryModels …

    …and TestLibraryModels
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7bf7497 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    37c7cb0 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    26c82dd View commit details
    Browse the repository at this point in the history
  21. Adding support for nullable type upper bounds considering Library mod…

    …els for generic types
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    cd0e659 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    1bf78df View commit details
    Browse the repository at this point in the history
  23. Adding method onOverrideTypeParameterUpperBound to Handler Interface …

    …and updating relevant implementations.
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    268022a View commit details
    Browse the repository at this point in the history
  24. Updating java docs

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5e5df6a View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    6c24cbd View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    32f84ac View commit details
    Browse the repository at this point in the history
  27. using putAll instead of loop

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    5f6d9a8 View commit details
    Browse the repository at this point in the history
  28. adding positive test case

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    dcc1507 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    4bba915 View commit details
    Browse the repository at this point in the history
  30. Revert "Adding EmptyLibraryModels abstract class for LibraryModels in…

    …terface"
    
    This reverts commit 81f8b7d.
    
    "Reverting EmptyLibraryModels changes"
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d24e9c5 View commit details
    Browse the repository at this point in the history
  31. Adding default implementations for typeVariablesWithNullableUpperBoun…

    …ds and nullableFields
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2ba7932 View commit details
    Browse the repository at this point in the history
  32. Removing redundant default implementations from ExampleLibraryModels …

    …and TestLibraryModels
    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2ea0b77 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    1c1316d View commit details
    Browse the repository at this point in the history
  34. documentation improvements

    msridhar authored and akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    924396c View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    24d5ed0 View commit details
    Browse the repository at this point in the history
  36. bug fix, still more to do

    msridhar authored and akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0de4d12 View commit details
    Browse the repository at this point in the history
  37. more fixes, still needs cleanup

    msridhar authored and akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    32aef72 View commit details
    Browse the repository at this point in the history
  38. docs

    msridhar authored and akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2acffb3 View commit details
    Browse the repository at this point in the history
  39. handler updates

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e1e23d1 View commit details
    Browse the repository at this point in the history
  40. handler updates

    akulk022 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fb23172 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge remote-tracking branch 'origin/library_models_Function_abhijitk…

    …7' into library_models_Function_abhijitk7
    
    # Conflicts:
    #	nullaway/src/main/java/com/uber/nullaway/CodeAnnotationInfo.java
    #	nullaway/src/main/java/com/uber/nullaway/LibraryModels.java
    #	nullaway/src/main/java/com/uber/nullaway/NullAway.java
    #	nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/CompositeHandler.java
    #	nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
    #	nullaway/src/test/java/com/uber/nullaway/NullAwayJSpecifyGenericsTests.java
    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bc0edd1 View commit details
    Browse the repository at this point in the history
  2. fixes

    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2dd0ca6 View commit details
    Browse the repository at this point in the history
  3. updating docs

    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    badfd16 View commit details
    Browse the repository at this point in the history
  4. fixes

    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6fc4337 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/library_models_Function_abhijitk…

    …7' into library_models_Function_abhijitk7
    
    # Conflicts:
    #	nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java
    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c97e8dc View commit details
    Browse the repository at this point in the history
  6. Revert "Prepare next development version."

    This reverts commit 00a317a.
    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    05fe856 View commit details
    Browse the repository at this point in the history
  7. Revert "Prepare for release 0.10.22."

    This reverts commit 986d060.
    akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    37a2008 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    57a2116 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e2beddc View commit details
    Browse the repository at this point in the history
  10. Fix crash with raw types in overrides in JSpecify mode (uber#899)

    We should skip checking for errors here instead of crashing
    
    (cherry picked from commit 091ac38)
    msridhar authored and akulk022 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f6996d1 View commit details
    Browse the repository at this point in the history