Various cleanups enabled by bumping minimum Java and Error Prone versions #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
============================================
+ Coverage 86.11% 86.17% +0.05%
+ Complexity 2040 2037 -3
============================================
Files 81 81
Lines 6707 6691 -16
Branches 1293 1290 -3
============================================
- Hits 5776 5766 -10
+ Misses 518 515 -3
+ Partials 413 410 -3 ☔ View full report in Codecov by Sentry. |
msridhar
changed the title
msridhar
commented
Jun 1, 2024
Comment on lines
+252
to
+255
| // NOTE: this code only handles the case where the message digest algorithm used when signing | ||
| // was SHA-256. Eventually we may need a more robust solution for other digest algorithms. | ||
| // E.g., on JDK 21, the default message digest algorithm is SHA-384, and this code does not | ||
| // work for that algorithm (the DIGEST_ENTRY_PATTERN regex is hardcoded for SHA-256) |
There was a problem hiding this comment.
Discovered by switching to the newer API for signing jars, which exposed this issue on JDK 21
yuxincs
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These warning suppressions and compatibility code are no longed needed given minimum JDK 11 and Error Prone 2.14.0