Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractConfig class #974

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Jun 7, 2024

AbstractConfig has only had one subclass for a long time, and I don't see any future scenario in which we add more. Removing AbstractConfig makes adding new NullAway options easier. We push down the code from AbstractConfig into ErrorProneCLIFlagsConfig and make the fields private and final instead of protected.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@msridhar msridhar enabled auto-merge (squash) June 8, 2024 00:45
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (646b7ab) to head (50c3440).

Files Patch % Lines
...va/com/uber/nullaway/ErrorProneCLIFlagsConfig.java 86.76% 5 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #974      +/-   ##
============================================
- Coverage     85.97%   85.94%   -0.03%     
+ Complexity     2046     2045       -1     
============================================
  Files            82       81       -1     
  Lines          6760     6761       +1     
  Branches       1301     1302       +1     
============================================
- Hits           5812     5811       -1     
- Misses          536      537       +1     
- Partials        412      413       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 87f16cd into uber:master Jun 8, 2024
10 of 11 checks passed
@msridhar msridhar deleted the remove-abstract-config branch June 8, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants