Support for Swift Package Manager #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kovpas
force-pushed
the
spm_support
branch
4 times, most recently
from
f4fc90b
to
635cc00
Compare
artman
reviewed
Nov 6, 2017
| @@ -47,3 +49,5 @@ open class LaunchRouter<InteractorType, ViewControllerType>: ViewableRouter<Inte | |||
| load() | |||
| } | |||
| } | |||
|
|
|||
| #endif | |||
Yeah, I'm leaving the decision up to you. In other opensource projects, people are usually asking about SPM support. Let's monitor if that's gonna be the case with RIBs and get back to the topic if it is. |
|
I don't think this is needed. SPM can't even build iOS projects yet. |
|
Yes, good point. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to
#if os(iOS)bunch of UIKit stuff, since SPM doesn't support it yet.Resolves #112