Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential for deadlocks in Worker binding. #582

Merged
merged 1 commit into from
May 12, 2023
Merged

Fix potential for deadlocks in Worker binding. #582

merged 1 commit into from
May 12, 2023

Conversation

psteiger
Copy link
Contributor

@psteiger psteiger commented May 12, 2023 •
edited
Loading

Removes nested unconfined lifecycle flow collection in Worker binding.

Instead of converting the lifecycleFlow into WorkerScopeProvider by using rxCompletable, just provide a WorkerScopeProvider backed by a CompletableSubject fed by the binding coroutine, so no nested unconfined coroutines form.

@psteiger
Fix potential for deadlocks in Worker binding.
f390e60 
Removes nested unconfined lifecycle flow collection.
@FranAguilera
Copy link
Contributor

FranAguilera commented May 12, 2023 •
edited
Loading

@psteiger Verified these changes on top #575 of everything looks good

image

@psteiger psteiger merged commit 4a59f54 into uber:main May 12, 2023
1 check passed
@psteiger psteiger deleted the deadlock branch May 18, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyvsmith tyvsmith tyvsmith approved these changes

@FranAguilera FranAguilera FranAguilera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psteiger @FranAguilera @tyvsmith