Set view tree owners in parent class #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteiger
approved these changes
Sep 12, 2023
Comment on lines
+96
to
+98
| ViewTreeLifecycleOwner.set(window.decorView, this) | ||
| ViewTreeViewModelStoreOwner.set(window.decorView, this) | ||
| ViewTreeSavedStateRegistryOwner.set(window.decorView, this) |
There was a problem hiding this comment.
I guess there are now setViewTreeXyz extensions that don't need to take in this
There was a problem hiding this comment.
this artifact was already there & the ext fun weren't visible so i stuck w/ this
idanakav
approved these changes
Sep 12, 2023
psteiger
reviewed
Sep 12, 2023
| @@ -81,4 +85,16 @@ abstract class CoreAppCompatActivity : AppCompatActivity() { | |||
| super.onActivityResult(requestCode, resultCode, data) | |||
| activityDelegate?.onActivityResult(this, requestCode, resultCode, data) | |||
| } | |||
|
|
|||
| /** | |||
| * [RibActivity] must call this since it does not use [ComponentActivity.setContentView] which | |||
There was a problem hiding this comment.
What happens for activities that extend from this and call setContentView? I imagine lifecycle owners get overwritten and that's ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #606 which moves the logic into the superclass so all
CoreAppCompatActivitysubclasses benefit from the updated logic