Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define ares self logger interface #72

Merged
merged 2 commits into from
Feb 1, 2019
Merged

define ares self logger interface #72

merged 2 commits into from
Feb 1, 2019

Conversation

lxning
Copy link
Contributor

@lxning lxning commented Jan 31, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   75.03%   75.05%   +0.02%     
==========================================
  Files          86       86              
  Lines       13325    13325              
==========================================
+ Hits         9998    10001       +3     
+ Misses       2537     2535       -2     
+ Partials      790      789       -1
Impacted Files Coverage Δ
utils/di.go 43.33% <40%> (ø) ⬆️
memstore/cuckoo_index.go 91.21% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51b06d...9ab0161. Read the comment docs.

@lucafuji
Copy link
Contributor

LGTM

@lxning lxning closed this Feb 1, 2019
@lxning lxning deleted the ares_log_interface branch February 1, 2019 00:04
@lxning lxning restored the ares_log_interface branch February 1, 2019 00:09
@lxning lxning reopened this Feb 1, 2019
@lxning lxning merged commit 22972f2 into master Feb 1, 2019
@lxning lxning deleted the ares_log_interface branch February 1, 2019 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants