-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test methods in subscribe proxies #160
Test methods in subscribe proxies #160
Conversation
@@ -80,6 +81,21 @@ public CompletableScoper(Maybe<?> lifecycle) { | |||
@Override public <E extends CompletableObserver> E subscribeWith(E observer) { | |||
return new AutoDisposeCompletable(maybeSource, scope()).subscribeWith(observer); | |||
} | |||
|
|||
@Override public TestObserver<Void> test() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are missing javadocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually nevermind missed this was the implementation and not the interface
* | ||
* @return a {@link TestObserver} | ||
*/ | ||
@CheckReturnValue TestObserver<Void> test(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change these javadocs to match the others and link the corresponding methods they're mirroring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #137