Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proguard rule for error prone annotations. #178

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Add proguard rule for error prone annotations. #178

merged 1 commit into from
Feb 22, 2018

Conversation

danh32
Copy link
Contributor

@danh32 danh32 commented Feb 22, 2018

Was seeing proguard build failures due to the @DoNotMock annotation.

This change adds an additional proguard rule to exclude the compileOnly errorprone annotations for all Android modules.

Tested by running a proguard build of Robinhood with the given rule.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll cut a patch release with these soon

@ZacSweers ZacSweers merged commit f32c0c3 into uber:master Feb 22, 2018
@danh32
Copy link
Contributor Author

danh32 commented Feb 22, 2018

Thanks! No rush, happy to wait for the next scheduled release if nothing else big is pending.

@danh32 danh32 deleted the proguard branch February 22, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants