Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): make the layout stable #1795

Merged
merged 3 commits into from Aug 26, 2019
Merged

fix(docs): make the layout stable #1795

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9461a0d
fix(docs): make the layout stable
tajo Aug 26, 2019
a100036
fix(docs): toc display update
tajo Aug 26, 2019
88b8404
fix(docs): simplify the GH link
tajo Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions documentation-site/components/layout.js
View file
Open in desktop
Expand Up @@ -180,10 +180,10 @@ class Layout extends React.Component<PropsT, {sidebarOpen: boolean}> {
<PencilIcon size={16} color="#666666" />
)}
$as="a"
href={githubUrl}
href={githubUrl.replace('/blob', '/edit')}
target="_blank"
size={SIZE.compact}
kind={KIND.tertiary}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter here but fyi - minimal and tertiary buttons are collapsed into the same style with the monochrome update

kind={KIND.minimal}
>
Edit this page
</Button>
Expand Down
6 changes: 4 additions & 2 deletions documentation-site/components/table-of-contents.js
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ import {useStyletron} from 'baseui';
function getPadding(componentType) {
const multiplier = Number(componentType.replace('h', ''));

return `${multiplier * 8}px`;
return `${multiplier * 10}px`;
}

const TableOfContents = props => {
Expand Down Expand Up @@ -75,7 +75,9 @@ const TableOfContents = props => {
marginTop: '-10px',
marginBottom: 0,
// set predictable width to avoid page relayout when table of content changes
width: 160,
width: '160px',
position: 'fixed',
top: '100px',
})}
>
{TOC.map(header => (
Expand Down