fix(modal): update close button colors #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrauh
requested review from
chasestarr,
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://baseui-git-fork-chrisrauh-update-modal-close-color.uber-ui-platform.now.sh |
chrisrauh
changed the title
chasestarr
approved these changes
Oct 8, 2019
gergelyke
changed the title
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Modal's close button to black per discussion with the design team.
Because the X icon is so thin, I followed the link colors for hover so there is enough contrast to be perceived. It is still pretty close colors but that's a more general system issue.
Scope