Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vrt): fix flakey vrt tests #2311

Merged
merged 7 commits into from Nov 20, 2019
Merged

test(vrt): fix flakey vrt tests #2311

merged 7 commits into from Nov 20, 2019

Conversation

sandgraham
Copy link
Contributor

@sandgraham sandgraham commented Nov 13, 2019 •
edited

  • fix flakiness for datepicker-range-highlight__noHighlight snapshot (biggest perpetrator)
  • fix unstable widths for some snapshots. mobile will always be 375 wide- desktop 1200 wide.
  • select__open snapshot has flaked in past but i haven't reproduced. it's been a while since it flaked so i'll look at it if it flakes again. likely a timing issue- either requiring a little more wait padding or a better selector to wait on.

@vercel
Copy link

vercel bot commented Nov 13, 2019 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/rn28e5wvq
🌍 Preview: https://baseweb-git-vrt-fix-flakey-tests.uber-ui-platform.now.sh

@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Nov 15, 2019
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2319

@vercel vercel bot temporarily deployed to staging November 15, 2019 00:42 Inactive
@sandgraham sandgraham closed this Nov 15, 2019
@sandgraham sandgraham reopened this Nov 15, 2019
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2319

@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2319

@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2319

@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2319

@sandgraham sandgraham closed this Nov 19, 2019
@sandgraham sandgraham reopened this Nov 19, 2019
@sandgraham sandgraham marked this pull request as ready for review November 19, 2019 18:48
@sandgraham sandgraham changed the title Work in progress: fix flakey vrt tests test(vrt): fix flakey vrt tests Nov 19, 2019
@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Nov 19, 2019
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2348

@vercel vercel bot temporarily deployed to staging November 19, 2019 19:34 Inactive
@sandgraham sandgraham merged commit 766ced1 into master Nov 20, 2019
@uber-baseweb-probots uber-baseweb-probots bot deleted the vrt/fix-flakey-tests branch November 20, 2019 19:11
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
@sandgraham @VladimirMilenko
test(vrt): fix flakey vrt tests (uber#2311)
cbfb05a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gergelyke gergelyke gergelyke approved these changes

@chasestarr chasestarr Awaiting requested review from chasestarr

@nadiia nadiia Awaiting requested review from nadiia

@tajo tajo Awaiting requested review from tajo

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
3 participants
@sandgraham @UberOpenSourceBot @gergelyke