Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(component-sizes): update to use the new script #2325

Merged
merged 4 commits into from Nov 18, 2019

Conversation

gergelyke
Copy link
Contributor

The previous approached created a virtual file system, so the gzip values were just estimations. This new setup uses the real file system, so the values will be more precise.

@vercel
Copy link

vercel bot commented Nov 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/lhfju8m3a
🌍 Preview: https://baseweb-git-update-size-guard.uber-ui-platform.now.sh

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

documentation-site/components/layout.js Outdated Show resolved Hide resolved
scripts/component-sizes.js Show resolved Hide resolved
Co-Authored-By: Chase Starr <chasestarr@gmail.com>
@vercel vercel bot temporarily deployed to staging November 18, 2019 16:51 Inactive
Co-Authored-By: Chase Starr <chasestarr@gmail.com>
@gergelyke gergelyke merged commit f1d5ade into master Nov 18, 2019
@uber-baseweb-probots uber-baseweb-probots bot deleted the update-size-guard branch November 18, 2019 17:31
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants