Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overrides): properly implement dynamic props value #2805

Merged
merged 6 commits into from Feb 7, 2020
Merged

fix(overrides): properly implement dynamic props value #2805

merged 6 commits into from Feb 7, 2020

Conversation

chasestarr
Copy link
Collaborator

@chasestarr chasestarr commented Feb 6, 2020 •
edited

Description

Previously implemented dynamic props overrides did not consider it needing the call time prop values provided to the component. Now, if the override props value is a function, the component returned from getOverrides is an HOC mapping the incoming props as defined by the function. See tests for examples of how it can be used.

codesandbox highlighting why previous iteration was not sufficient

Scope

  • Patch: Bug Fix

@vercel
Copy link

vercel bot commented Feb 6, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/5f9st87z4
✅ Preview: https://baseweb-git-fix-overrides-props-mapping.uber-ui-platform.now.sh

@vercel vercel bot temporarily deployed to Preview February 7, 2020 16:41 Inactive
@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Feb 7, 2020
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2814

@chasestarr chasestarr merged commit 6b6d10c into master Feb 7, 2020
@uber-baseweb-probots uber-baseweb-probots bot deleted the fix-overrides-props-mapping branch February 7, 2020 16:59
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
@chasestarr @UberOpenSourceBot @VladimirMilenko
fix(overrides): properly implement dynamic props value (uber#2805)
23207e2 
* fix(overrides): properly implement dynamic props value

* fix(overrides): handles style override

* chore(component-sizes): update

* test(vrt): update visual snapshots for 982bc7a [skip ci] (uber#2814)

Co-authored-by: UberOpenSourceBot <33560951+UberOpenSourceBot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajo tajo tajo approved these changes

@nadiia nadiia nadiia approved these changes

@gergelyke gergelyke Awaiting requested review from gergelyke

@sandgraham sandgraham Awaiting requested review from sandgraham

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
4 participants
@chasestarr @UberOpenSourceBot @tajo @nadiia