build(vrt): sanitize branch names #2948
Conversation
sandgraham
requested review from
chasestarr,
gergelyke,
nadiia and
tajo
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/dieot298c |
| function sanitizeBranchName(branchName) { | ||
| // Colons are not permitted in git branch names and for some reason | ||
| // Buildkite will report the branch name as "user:branch". | ||
| return branchName.replace(/:/g, '-'); |
There was a problem hiding this comment.
Should we sanitize even more characters and use some 3rd party lib?
There was a problem hiding this comment.
This should be fine since we are only protecting against the colon that buildkite might add to the actual branch name. The user's actual branch name can't be created in the first place if it has bad characters. Not sure why buildkite does this, but I think if the branch is called master - buildkite will append the repo owner (ex: sandgraham:master).
* build(vrt): sanitize branch names * Update vrt/ci.js
No description provided.