feat(data-table): add onIncludedRowsChange callback #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasestarr
requested review from
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/nj8lzecr9 |
gergelyke
approved these changes
Mar 27, 2020
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3131 |
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
sandgraham
approved these changes
Mar 27, 2020
|
Typescript defs on |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d654d54:
|
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
* feat(data-table): add onIncludedRowsChange callback * test(vrt): update visual snapshots for 893c273 [skip ci] (uber#3131) Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com> * fix(data-table): lint Co-authored-by: UberOpenSourceBot <33560951+UberOpenSourceBot@users.noreply.github.com> Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/uber/baseweb/issues/3099
Description
Adds a new prop to DataTable that is called when the included rows in the table change. This is useful if the application needs to do something with the filtered/sorted 'view' that the user has configured. Please note, that it's important to have a stable function provided to this prop. See here for an example. If the function is in-lined, it causes an update loop.
Scope