feat(combobox): adds onSubmit callback and close handler #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasestarr
requested review from
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/nl10dnasa |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a66b0a:
|
gergelyke
approved these changes
Jul 16, 2020
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3501 |
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
|
@chasestarr this is great! Any way we can pass the input value through to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/uber/baseweb/issues/3492
Description
Adds a new
onSubmitcallback that will fire in the same step as a parent form element'sonSubmitattribute. This callback includes acloseListboxhandler that can be used in response to pressing enter when not focused on a listbox option@jonsadka Take a look at the included
.scenario.jsfile. I think this should do what you're looking for. Clicking on a separate button should already close the listbox. If that's not working for you, can you please share a repro?Scope
Minor: New Feature