Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): update designs #3566

Merged
merged 43 commits into from Aug 21, 2020
Merged

feat(tag): update designs #3566

merged 43 commits into from Aug 21, 2020

Conversation

sandgraham
Copy link
Contributor

@sandgraham sandgraham commented Jul 30, 2020 •
edited

Fixes #3452

  • Simplifies Tag design by removing light variant and hover states on the X toggle.
  • Adds purple, brown, and orange tag colors. These are hard-coded to our colors in the tokens module. I also added "primitive" (blue/green/etc) aliases for each "semantic" (accent/positive/etc) KIND value.
  • Removes light variants since we no longer have designs for them. If you have light selected, you get outline now.
  • Simplifies hover states.
  • neutral looks the same as primary by default now (customizable in theme still)
  • Improve logic for determining custom shades.
  • Deprecates isHovered and isFocused.
  • Adds new Tag sizes.

@vercel
Copy link

vercel bot commented Jul 30, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/c5azyy85g
✅ Preview: https://baseweb-git-tag-updates.uber-ui-platform.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9543e65:

Sandbox Source
Basic usage Configuration

@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Jul 30, 2020
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3567

@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3567

@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3567

@gergelyke
Copy link
Contributor

Screen Shot 2020-08-12 at 2 55 50 PM

there seems to be an error on the doc size when you change the size prop

@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Aug 18, 2020
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3655

@UberOpenSourceBot
test(vrt): update visual snapshots for 03a22e2 [skip ci] (#3655)
931beb6 
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
Graham Murdoch added 4 commits August 19, 2020 17:08
refactor: new specs
b02026d 
removes hover, removes white, deprecates certain theme properties
refactor: neutral
abf9901
fix: gray
361fe4e
docs: remove neutral from example
ffa1949
@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Aug 20, 2020
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3665

@UberOpenSourceBot
test(vrt): update visual snapshots for ffa1949 [skip ci] (#3665)
b139de6 
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Aug 20, 2020
Merged
@UberOpenSourceBot
Copy link
Collaborator

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #3673

@UberOpenSourceBot
test(vrt): update visual snapshots for 8734012 [skip ci] (#3673)
9543e65 
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
@sandgraham sandgraham merged commit 2145c91 into master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasestarr chasestarr chasestarr approved these changes

@nadiia nadiia Awaiting requested review from nadiia

@tajo tajo Awaiting requested review from tajo

@gergelyke gergelyke Awaiting requested review from gergelyke

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
4 participants
@sandgraham @UberOpenSourceBot @gergelyke @chasestarr