Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): focus respects rounded corners #3726

Merged
merged 2 commits into from Sep 10, 2020
Merged

Conversation

sandgraham
Copy link
Contributor

@sandgraham sandgraham commented Sep 2, 2020

Uses box-shadow instead of outline to respect when folks use buttonBorderRadius in their theme.

Fixes #3647 .

@vercel
Copy link

vercel bot commented Sep 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/ft6j81qwq
✅ Preview: https://baseweb-git-button-focus-rounded.uber-ui-platform.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ced191:

Sandbox Source
Basic usage Configuration

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants