Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): keep dropdown options highlighted #4100

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

ksnyder9801
Copy link
Contributor

Fixes #4098

Description

Adds a "internal" forceHighlight prop to StatefulMenu that Dropdown can use.
The prop disables the mouseLeave highlight removal and sets the highlight to the first item if there are 1 or more items but no highlight.

Scope

Patch: Bug Fix

@vercel
Copy link

vercel bot commented Mar 2, 2021

@ksnyder9801 is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c7d9039:

Sandbox Source
Basic usage Configuration
Base Web - Select Issue #4098

@vercel
Copy link

vercel bot commented Mar 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/7sZXSTVWyU2C7E89YuMmpLSjKgu4
✅ Preview: https://baseweb-git-fork-ksnyder9801-ks-4098-uber-ui-platform.vercel.app

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Thank you

@chasestarr chasestarr merged commit e21ca85 into uber:master Mar 3, 2021
@ksnyder9801 ksnyder9801 deleted the ks-4098 branch March 3, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants