Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): pass order sharedprop to prev and next button (#4122) #4123

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

hardikmodi1
Copy link
Contributor

Pass order as shared prop from calendar header to previous and next button

Description

Pass order as shared prop so that consumer can style the respective buttons based on prop. For example one may not want to show the previous button for 2nd month when monthsShown is equal to 2. For the purpose she/he can style that button using this $order prop.

Fixes #4122

@vercel
Copy link

vercel bot commented Mar 15, 2021

@hardikmodi1 is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 72abb45:

Sandbox Source
Basic usage Configuration

@hardikmodi1 hardikmodi1 force-pushed the datepicker-calendar-order-prop branch from 4061a04 to 3b0cc31 Compare March 15, 2021 17:54
@vercel
Copy link

vercel bot commented Mar 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/EbrwM5aiQDVGc3cPZUYE816xttMq
✅ Preview: https://baseweb-git-fork-hardikmodi1-datepicker-calendar-bd8620.vercel.app

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@chasestarr chasestarr merged commit 72a3011 into uber:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants