docs(select): update example to render correctly #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamernest
requested review from
chasestarr,
lhbrennan and
tajo
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/J7qXu9eRk1df8ksFLmEmiFzdHgng |
williamernest
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 22170b8:
|
chasestarr
approved these changes
Aug 13, 2021
leyanlo
added a commit
that referenced
this pull request
Apr 13, 2022
Update example to render correctly, copying the fix from #4461 for #3991 to the JS file.
williamernest
pushed a commit
that referenced
this pull request
Apr 13, 2022
Update example to render correctly, copying the fix from #4461 for #3991 to the JS file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3991
Padding on the StyledList isn't accounted for with the react-window example, causing a small scroll effect on the containing element. Removing the style prop from the list fixes the issue.
Scope
Doc update