-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): handle open click when inside native label #4466
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/87Aavocnn97pjQm6sz84RhEZ8f91 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed5395e:
|
<label htmlFor="searchable-native-label"> | ||
Native searchable | ||
<Select | ||
id="searchable-native-label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we include a test that does not specify id
and htmlFor
attributes? One of the benefits of wrapping form elements in <label>
is that the browser automatically wires up the connection. I realize that's not going to work for every complex form component, but it's a valid option for <Select>
after the change in #4402.
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround!
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4474 |
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
Thank you! |
Description
Fixes bug where
Select
would not open listbox on click when inside a nativelabel
element. For reference, see reporting comment here: #4402 (comment)Scope
Patch: Bug Fix