Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-nav-bar): resolve forward ref error #4475

Merged
merged 3 commits into from
Aug 20, 2021
Merged

fix(app-nav-bar): resolve forward ref error #4475

merged 3 commits into from
Aug 20, 2021

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented Aug 20, 2021

Fixes #4082

Fixes the following error printed in the console when opening the dropdown or drawer menu.
Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/GRGe6yAcHbZGehJnWbzXTTYMEKVZ
✅ Preview: https://baseweb-git-fixappnav-uber-ui-platform.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 475822c:

Sandbox Source
Basic usage Configuration
sleepy-napier-isn4e Issue #4082

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4476

1 similar comment
@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4476

@UberOpenSourceBot
Copy link
Contributor

Visual changes have been resolved. #4476 has been closed. If future commits on fix_app_nav trigger visual changes, a new snapshot branch will be created and a new PR will be opened.

@williamernest williamernest marked this pull request as ready for review August 20, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants