Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): add prop to always render 6 rows in datepicker (#4465) #4490

Merged
merged 3 commits into from
Aug 31, 2021
Merged

fix(datepicker): add prop to always render 6 rows in datepicker (#4465) #4490

merged 3 commits into from
Aug 31, 2021

Conversation

hardikmodi1
Copy link
Contributor

Fixes #4465

Description

Added prop named fixedHeight in datepicker to always render 6 rows in calendar

Scope

Minor: New Feature

@vercel
Copy link

vercel bot commented Aug 30, 2021

@hardikmodi1 is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7fa89df:

Sandbox Source
Basic usage Configuration

williamernest
williamernest reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a story test for this, just to catch any regressions in the future? Other than that I think this looks good to go.

src/datepicker/types.js
@@ -116,7 +116,9 @@ export type WeekPropsT<T = Date> = {
value: ?T | Array<T>,
};

export type MonthPropsT<T = Date> = WeekPropsT<T>;
export type MonthPropsT<T = Date> = WeekPropsT<T> & {
fixedHeight?: boolean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this prop to the index.d.ts file as well?

@vercel
Copy link

vercel bot commented Aug 30, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/F2kVBkC4kuq8dXmGwUzCFFDFrgWs
✅ Preview: https://baseweb-git-fork-hardikmodi1-datepicker-564b18-uber-ui-platform.vercel.app

@williamernest williamernest merged commit f8e9ecd into uber:master Aug 31, 2021
khudiono-uber pushed a commit that referenced this pull request Sep 9, 2021
@hardikmodi1 @williamernest @khudiono-uber
fix(datepicker): add prop to always render 6 rows in datepicker (#446…
d2881e3 
…5) (#4490)

* fix(datepicker): add prop to always render 6 rows in datepicker (#4465)

* fix(datepicker): add prop in ts file

Co-authored-by: Will Ernest <williame@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamernest williamernest williamernest approved these changes

@chasestarr chasestarr Awaiting requested review from chasestarr

@lhbrennan lhbrennan Awaiting requested review from lhbrennan

@tajo tajo Awaiting requested review from tajo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hardikmodi1 @williamernest