fix(layout-grid): better checks for custom grid props #4502
Conversation
phou87
requested review from
chasestarr,
lhbrennan,
tajo and
williamernest
as code owners
|
@phou87 is attempting to deploy a commit to the Uber UI Platform Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/5ovG3gaJkKMLvgSLELJCzUYBugfe |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2e6ac17:
|
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: phou87#3 |
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: phou87#3 |
test(vrt): update visual snapshots for phou87:grid-checks [skip ci]
|
Thank you. Alpha tests look good |
* fix(layout-grid): better checks for custom grid props * test(vrt): update visual snapshots for fe291d6 [skip ci] Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
Use a better check for when custom grid props are passed in.
Description
Responsive props allow for single values, even outside of an array (e.g. gridMargins={0}), so if a falsey value was passed it would be ignored. This PR fixes the check to allow falsey values such as 0 for grid props.
Scope
Patch: Bug Fix