Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-table): add example for customized column sort #4535

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

im-adithya
Copy link
Contributor

Fixes #3488

Description

Added an example for customized column sort as requested in the above issue.

Scope

Minor: New example

@vercel
Copy link

vercel bot commented Sep 20, 2021

@im-adithya is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b1ee00:

Sandbox Source
Basic usage Configuration

@vercel
Copy link

vercel bot commented Sep 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/4knfL7qiFXEpgr2aUbwKPDMWjoSJ
✅ Preview: https://baseweb-git-fork-im-adithya-task-sort-example-uber-ui-platform.vercel.app

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Do you mind reducing the example scope to only highlight the custom column?

@im-adithya
Copy link
Contributor Author

@chasestarr Done! Does this seem good to you?

Screenshot from 2021-09-25 01-10-16

Copy link
Collaborator

@chasestarr chasestarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@chasestarr chasestarr merged commit 8cb3d14 into uber:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants