Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): correct initial content position #4700

Merged
merged 6 commits into from
Jan 18, 2022
Merged

fix(popover): correct initial content position #4700

merged 6 commits into from
Jan 18, 2022

Conversation

chasestarr
Copy link
Collaborator

@chasestarr chasestarr commented Jan 14, 2022 •
edited

fixes https://github.com/uber/baseweb/issues/4693

Introduced in #4630 example
Added new snapshot to reproduce the incorrect position.

Here is a screenshot showing fixed behavior described in reporting issue
Screen Shot 2022-01-14 at 4 39 56 PM

Scope

Patch: Bug Fix

@vercel
Copy link

vercel bot commented Jan 14, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/9GVJ3ouh6iCNqfFtW5jPe4zECddp
✅ Preview: https://baseweb-git-popover-position-uber-ui-platform.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47b93a4:

Sandbox Source
Basic usage Configuration

@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Jan 14, 2022
Merged
@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4701

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4701

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4701

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4701

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #4701

@UberOpenSourceBot
test(vrt): update visual snapshots for 19d68c3 (#4701)
47b93a4 
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
@chasestarr chasestarr changed the title fix(popover): create snapshot to repro incorrect position fix(popover): correct initial content position Jan 18, 2022
@chasestarr chasestarr merged commit 16f10e5 into master Jan 18, 2022
@LeonaYoung LeonaYoung mentioned this pull request Jan 28, 2022
Merged
@chasestarr chasestarr deleted the popover-position branch February 22, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhbrennan lhbrennan lhbrennan approved these changes

@tajo tajo Awaiting requested review from tajo

@williamernest williamernest Awaiting requested review from williamernest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chasestarr @UberOpenSourceBot @lhbrennan