fix(eslint): add more tests and rewrite typography logic #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamernest
requested review from
chasestarr,
lhbrennan and
tajo
as code owners
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/7EkrwW2Ji8s2ouC6BJKLwyFN82Mh |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0c1112:
|
tajo
approved these changes
Jan 18, 2022
chasestarr
reviewed
Jan 18, 2022
packages/eslint-plugin-baseui/__tests__/deprecated-component-api.test.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the typography eslint logic by pulling it one level higher (executes once per import statement instead of on each import in a statement). It tracks previous imports, and renames a component to reuse the previous import instead of duplicating imports.
Updates the typography array with a map, and tracks what components need actions in the current document (based on import presence) so performance should be much better.