Dont leak theme properties between themes #5254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kira-bruneau
requested review from
chasestarr,
tajo and
lhbrennan
as code owners
|
|
kira-bruneau
force-pushed
the
dont-leak-theme-properties-between-themes
branch
from
8c27cc4
to
4be2394
Compare
kira-bruneau
force-pushed
the
dont-leak-theme-properties-between-themes
branch
from
4be2394
to
59c836f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found this really strange bug where certain properties defined in one theme would leak into the other (eg. any typography property). I eventually narrowed down the problem to the
createThemefunctions mutating shared state.The fix is pretty straightforward, instead of mutating the shared state, the create functions now deep merge into an empty object. (this same pattern is already used in most other calls to
deepMerge).Scope
Patch: Bug Fix (although this is also a potentially breaking change if apps are designed to rely on this leak)