fix(table-semantic): remove padding-right from sortable columns #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove padding-right from sortable columns to match documentation: https://base.uber.com/6d2425e9f/p/901301-data-table/t/4633ea - Avoid right-aligning text for numeric columns to match documentation. - Add `background: inherit` to sort icon so it appears in front of text to match documentation. This should help us with data-dense tables, where we have many columns that need to fit on a page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
f12b23e
|
| Status: | 🚫 Build failed. |
|
Moving to web-code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background: inheritto sort icon so it appears in front of text to match documentation.This should help us with data-dense tables, where we have many columns that need to fit on a page.