Add missing metrics from go client (#379) #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aai95
force-pushed
the
feature/add-metrics-379
branch
from
5362275
to
e955f9f
Compare
|
@vancexu could you please make a review? |
|
Dear @mfateev could you please review this PR? |
meiliang86
reviewed
Sep 14, 2020
src/main/java/com/uber/cadence/internal/replay/DecisionsHelper.java
Outdated
Show resolved
Hide resolved
src/test/java/com/uber/cadence/internal/replay/ReplayDeciderCacheTests.java
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution @aai95 ! |
aai95
force-pushed
the
feature/add-metrics-379
branch
from
e955f9f
to
ee51c04
Compare
aai95
force-pushed
the
feature/add-metrics-379
branch
from
ee51c04
to
4250b1e
Compare
|
@meiliang86 should I fix something else or we just wait for review? |
|
Thank you @meiliang86 |
mkolodezny
pushed a commit
to mkolodezny/cadence-java-client
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric
decision-task-force-completedwas addedMetric
non-deterministic-errorwas added