Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Delay Start in Java Client #640

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

demirkayaender
Copy link
Contributor

This feature was implemented for Go client for a while back. This PR adds it to the Java client.

Test:

Window1:

~/cadence$ ./cadence-server start

Window2:

~/cadence-java-client$ USE_DOCKER_SERVICE=true ./gradlew test --tests "*.testDelayStart*"

Also tested with HelloActivity from java samples

@demirkayaender demirkayaender requested a review from a team September 28, 2021 05:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 907

  • 16 of 22 (72.73%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 71.168%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/cadence/client/WorkflowOptions.java 10 12 83.33%
src/main/java/com/uber/cadence/internal/common/StartWorkflowExecutionParameters.java 3 5 60.0%
src/main/java/com/uber/cadence/internal/external/GenericWorkflowClientExternalImpl.java 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java 1 82.46%
src/main/java/com/uber/cadence/internal/worker/BlockCallerPolicy.java 1 62.5%
src/main/java/com/uber/cadence/internal/worker/Poller.java 1 82.46%
Totals Coverage Status
Change from base Build 879: -0.01%
Covered Lines: 10725
Relevant Lines: 15070

💛 - Coveralls

@demirkayaender demirkayaender merged commit 9898a41 into uber:master Sep 29, 2021
@demirkayaender demirkayaender deleted the delayStart branch September 29, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants