Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to CI pipeline #222

Merged
merged 6 commits into from
Nov 20, 2020
Merged

Add unit tests to CI pipeline #222

merged 6 commits into from
Nov 20, 2020

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Nov 20, 2020

Adding unit tests to CI pipeline so that if the tests fail it will break the CI build pipeline.
Set timezone to run in UTC regardless of where the tests are run (moment will default to current timezone if not specified).
Added fixes for unit tests which were all related to running tests in a UTC timezone (instead of PST).
Run npm run test:unit to run unit tests.

Screenshots

Build failed
Screen Shot 2020-11-20 at 10 09 01 AM

Build passing
Screen Shot 2020-11-20 at 1 34 16 PM

@just-at-uber just-at-uber marked this pull request as ready for review November 20, 2020 21:48
@just-at-uber just-at-uber merged commit d6fc799 into master Nov 20, 2020
@just-at-uber just-at-uber deleted the fix/unit-test branch November 20, 2020 22:06
@just-at-uber just-at-uber mentioned this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants