Fix/script ordering #223
Merged
Fix/script ordering #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-at-uber
commented
Nov 24, 2020
| export default { | ||
| name: 'loading-spinner', | ||
| }; | ||
| </script> |
There was a problem hiding this comment.
creating <script> tag here as it is missing.
just-at-uber
commented
Nov 24, 2020
| export default { | ||
| name: 'archival-table', | ||
| }; | ||
| </script> |
There was a problem hiding this comment.
creating <script> tag here as it is missing.
mkolodezny
approved these changes
Nov 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordering
<script>tag to be the first element in a.vuefile.Used new lint rule to achieve & enforce this rule (see eslint-plugin-vue/component-tags-order for more information).
Also for two of the files (
client/components/loading-spinner.vue&client/routes/domain/workflow-archival/components/archival-table.vue) have created a<script>tag as these were missing.This is needed in order to inject license headers correctly, as this is a limitation of the library (see #220 & Stuk/eslint-plugin-header#32 for more information).
No other changes are included in this PR.
Screenshots
Before changes with lint rule
After changes with lint rule
