Skip to content

Commit

Permalink
After review
Browse files Browse the repository at this point in the history
  • Loading branch information
abhishekj720 committed May 8, 2024
1 parent 955a302 commit 008c622
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions common/domain/dlq_message_handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ func TestDLQMessageHandler_Start(t *testing.T) {
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
ctrl := gomock.NewController(t)
defer ctrl.Finish()

mockQueue := NewMockReplicationQueue(ctrl)
mockReplicationTaskExecutor := NewMockReplicationTaskExecutor(ctrl)
mockLogger := testlogger.New(t)
Expand All @@ -160,7 +158,7 @@ func TestDLQMessageHandler_Start(t *testing.T) {
handler.Start()
mockedTime.Advance(5 * time.Minute)
defer handler.Stop()
assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status), assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status), "Handler did not reach the expected status for test case: %s", tc.name))
assert.Equal(t, tc.expectedStatus, atomic.LoadInt32(&handler.status))
})
}
}
Expand Down Expand Up @@ -190,9 +188,6 @@ func (s *dlqMessageHandlerSuite) TestStop() {
s.Run(test.name, func() {
atomic.StoreInt32(&s.dlqMessageHandler.status, test.initialStatus)
s.dlqMessageHandler.Stop()
if test.shouldStop {
s.dlqMessageHandler.logger.Info("Domain DLQ handler shutting down.")
}
s.Equal(test.expectedStatus, atomic.LoadInt32(&s.dlqMessageHandler.status))
})
}
Expand Down

0 comments on commit 008c622

Please sign in to comment.