Introduce pull based replicator that does not use kafka #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
August 12, 2019 12:00
wxing1292
reviewed
Aug 12, 2019
wxing1292
reviewed
Aug 12, 2019
client/frontend/client.go
Outdated
| @@ -643,3 +643,18 @@ func (c *clientImpl) getRandomClient() (workflowserviceclient.Interface, error) | |||
|
|
|||
| return client.(workflowserviceclient.Interface), nil | |||
| } | |||
|
|
|||
| func (c *clientImpl) GetReplicationTasks( | |||
There was a problem hiding this comment.
suggestion: GetReplicationTasks -> GetReplicationMessages
There was a problem hiding this comment.
Thanks. I need lots of suggestion on names. Please keep them coming :)
wxing1292
reviewed
Aug 12, 2019
| @@ -246,6 +255,14 @@ type ( | |||
| RPCAddress string `yaml:"rpcAddress"` | |||
| } | |||
|
|
|||
| // ReplicationConsumerConfig contains config for replication consumer | |||
| ReplicationConsumerConfig struct { | |||
There was a problem hiding this comment.
are we going to officially support 2 means to deliver replication messages?
I hope not
There was a problem hiding this comment.
I don't think we need to support both. This is mainly for migration and testing purpose. Once we migrate to the new model we can completely remove kafka related stuffs.
There was a problem hiding this comment.
then i guess, the preference is to use dynamic config, not this.
wxing1292
reviewed
Aug 12, 2019
wxing1292
reviewed
Aug 12, 2019
wxing1292
reviewed
Aug 14, 2019
| @@ -23,6 +23,7 @@ package history | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -21,6 +21,7 @@ | |||
| package history | |||
|
|
|||
| import ( | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -21,6 +21,7 @@ | |||
| package history | |||
|
|
|||
| import ( | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -21,6 +21,7 @@ | |||
| package history | |||
|
|
|||
| import ( | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -22,6 +22,7 @@ package history | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -22,6 +22,7 @@ package history | |||
|
|
|||
| import ( | |||
| "errors" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| token: &r.ReplicationToken{ShardID: common.Int32Ptr(int32(p.shard.GetShardID())), TaskID: common.Int64Ptr(p.readLevel)}, | ||
| token: &r.ReplicationToken{ | ||
| ShardID: common.Int32Ptr(int32(p.shard.GetShardID())), | ||
| LastRetrivedMessageId: common.Int64Ptr(p.lastProcessedMessageID), |
wxing1292
reviewed
Aug 14, 2019
| @@ -23,6 +23,7 @@ package history | |||
| import ( | |||
| ctx "context" | |||
| "errors" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -24,6 +24,7 @@ import ( | |||
| "context" | |||
| "encoding/json" | |||
| "errors" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -22,6 +22,7 @@ package history | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -24,6 +24,7 @@ import ( | |||
| "context" | |||
| "encoding/json" | |||
| "errors" | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
reviewed
Aug 14, 2019
| @@ -21,6 +21,7 @@ | |||
| package history | |||
|
|
|||
| import ( | |||
| "github.com/golang/mock/gomock" | |||
wxing1292
approved these changes
Aug 14, 2019
longquanzheng
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain replication is still going through kafka, which will be addressed in a follow up PR.