Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filestore implementation for visibility archival #2467

Merged
merged 9 commits into from Aug 29, 2019
Merged

Filestore implementation for visibility archival #2467

merged 9 commits into from Aug 29, 2019

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Aug 28, 2019

Task 2 of #2452

andrewjdawson2016
andrewjdawson2016 approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@andrewjdawson2016 andrewjdawson2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@coveralls
Copy link

coveralls commented Aug 29, 2019 •
edited

Coverage Status

Coverage increased (+0.5%) to 67.247% when pulling 5b500cf on yycptt:filestore-visibility into 05b4197 on uber:master.

@yycptt yycptt merged commit f8bf786 into uber:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewjdawson2016 andrewjdawson2016 andrewjdawson2016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yycptt @coveralls @andrewjdawson2016