Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ttl max value #3627

Merged
merged 2 commits into from Oct 12, 2020
Merged

Update ttl max value #3627

merged 2 commits into from Oct 12, 2020

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Oct 12, 2020

What changed?
Update max TTL value to 5 years

Why?
There is a max timestamp Cassandra supports. Use the max timestamp, some weird behavior could happen.

How did you test it?
DB interaction test

Potential risks

@yux0 yux0 requested review from yycptt and a team October 12, 2020 17:31
Copy link
Contributor

@vancexu vancexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what is the weird error you are seeing caused by this?

@yux0
Copy link
Contributor Author

yux0 commented Oct 12, 2020

Just curious what is the weird error you are seeing caused by this?

From https://docs.datastax.com/en/dse-trblshoot/doc/troubleshooting/recoveringTtlYear2038Problem.html, the data could immediately expire. This explains what we see in the matching task loss

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 68.81% when pulling 55add48 on max_ttl into 9f58fc4 on master.

@yux0 yux0 merged commit 90ae01b into master Oct 12, 2020
@yux0 yux0 deleted the max_ttl branch October 12, 2020 18:35
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants